fix(signer-ledger): use SIGN_ETH_EIP_712 instruction

[Karrq]

Motivation

Signing EIP712 messages thru alloy_network::TxSigner's sign_transaction results in the usage of SIGN instruction which does not support EIP712 messages.

Solution

Detect if the incoming tx is indeed a EIP712 transaction and dispatch to the appropriate method

PR Checklist

• Added Tests
• Added Documentation
• Breaking changes

[mattsse]

not that familiar with this api

wdyt @DaniPopes

[DaniPopes]

There's no such thing as a EIP-712 transaction, nor does any of the existing transaction ever return EIP-712-encoded data, so I don't know what this is trying to accomplish.

[DaniPopes]

Nevermind, apparently there is #142
Please add a comment for this
cc @prestwich

[Karrq]

This allows foundry-zksync to sign transactions using ledger, since we make use of sign_transaction to sign the encoded eip712 transacion.

[Karrq]

Hey guys, any update on this? Please let me know if the bugfix is not clear.

The main issue that this addresses is the correct dispatch of EIP712 encoded tx, since TxSigner::sign_transaction is the only entrypoint available from foundry.
alloy-signer-ledger already supports EIP712 signing using sign_typed_data, but this method was just not accessible from sign_transaction, which is why the PR was made.

Please let me know if you any concerns so I may address them :)