feat: serde helpers for hashmaps and btreemaps with quantity key types #1579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevencartavia
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
emhane
as code owners
stevencartavia
changed the title
onbjerg
previously requested changes
Oct 29, 2024
crates/serde/src/quantity.rs
Outdated
| @@ -164,6 +164,133 @@ pub mod u128_vec_vec_opt { | |||
| } | |||
| } | |||
|
|
|||
| /// Serde functions for encoding a hashmap of primitive numbers using the Ethereum "quantity" | |||
There was a problem hiding this comment.
Suggested change
| /// Serde functions for encoding a hashmap of primitive numbers using the Ethereum "quantity" | |
| /// Serde functions for encoding a `HashMap` of primitive numbers using the Ethereum "quantity" |
crates/serde/src/quantity.rs
Outdated
| use serde::{de::MapAccess, ser::SerializeMap, Deserializer, Serializer}; | ||
| use std::collections::HashMap; | ||
|
|
||
| /// Serializes a hashmap of primitive numbers as a "quantity" hex string. |
There was a problem hiding this comment.
Suggested change
| /// Serializes a hashmap of primitive numbers as a "quantity" hex string. | |
| /// Serializes a `HashMap` of primitive numbers as a "quantity" hex string. |
crates/serde/src/quantity.rs
Outdated
| map_ser.end() | ||
| } | ||
|
|
||
| /// Deserializes a hashmap of primitive numbers from a "quantity" hex string. |
There was a problem hiding this comment.
Suggested change
| /// Deserializes a hashmap of primitive numbers from a "quantity" hex string. | |
| /// Deserializes a `HashMap` of primitive numbers from a "quantity" hex string. |
crates/serde/src/quantity.rs
Outdated
| } | ||
| } | ||
|
|
||
| /// Serde functions for encoding a BTreeMap of primitive numbers using the Ethereum "quantity" |
There was a problem hiding this comment.
Suggested change
| /// Serde functions for encoding a BTreeMap of primitive numbers using the Ethereum "quantity" | |
| /// Serde functions for encoding a `BTreeMap` of primitive numbers using the Ethereum "quantity" |
mattsse
requested changes
Oct 29, 2024
crates/serde/src/quantity.rs
Outdated
| where | ||
| A: MapAccess<'de>, | ||
| { | ||
| let mut values = HashMap::new(); |
There was a problem hiding this comment.
this can pre allocate with the map's size hint
crates/serde/src/quantity.rs
Outdated
| use std::collections::HashMap; | ||
|
|
||
| /// Serializes a hashmap of primitive numbers as a "quantity" hex string. | ||
| pub fn serialize<K, V, S>(map: &HashMap<K, V>, serializer: S) -> Result<S::Ok, S::Error> |
There was a problem hiding this comment.
this should also relax the hasher generic, see for ref https://github.com/serde-rs/serde/blob/418062165f9fe395461db9f61569c3142c584854/serde/src/ser/impls.rs#L495-L506
crates/serde/src/quantity.rs
Outdated
| } | ||
|
|
||
| /// Deserializes a hashmap of primitive numbers from a "quantity" hex string. | ||
| pub fn deserialize<'de, K, V, D>(deserializer: D) -> Result<HashMap<K, V>, D::Error> |
There was a problem hiding this comment.
this should also relax the hasher
mattsse
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1502
Motivation
Existing
mod vecimplementationSolution
Created the same for hashmaps/btreemaps with quantity key types and tests.
PR Checklist