feat(consensus-tx): enable fast is_create
#1683
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
alloy-consensus::Transaction
implementors didn't have a cheap way to check if the transaction was aCreate
. They had to go throughkind
which copies the 21-byteTxKind
. This may scale poorly for code that processes (hundreds of) thousands of transactions per second: paradigmxyz/reth#12838.Solution
Add
is_create
to the trait that allows fast non-allocating implementation. I considered makingkind
returns&TxKind
but transactions like EIP-4844, 7702, etc. only store anAddress
and it would be bad if we forced them to promote it toTxKind
.PR Checklist