Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: uninstall_filter in Provider trait #1685

Merged
merged 3 commits into from
Nov 25, 2024
Merged

feat: uninstall_filter in Provider trait #1685

merged 3 commits into from
Nov 25, 2024

Conversation

eshaan7
Copy link
Contributor

@eshaan7 eshaan7 commented Nov 25, 2024

Related: #1681.

Motivation

Right now cannot call eth_uninstallFilter JSON-RPC method without using raw_request which is not ideal.

Solution

Adds a new uninstall_filter method to Provider trait.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@mattsse mattsse merged commit 5fcbb2d into alloy-rs:main Nov 25, 2024
26 checks passed
@eshaan7 eshaan7 deleted the fix/gh-1681-uninstall_filter branch November 25, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@emhane emhane Awaiting requested review from emhane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eshaan7 @mattsse