fix(provider): use BoxTransport
in on_anvil_*
#1693
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the
on_anvil_*
methods on the provider builder return a provider based onHttp<Client>
transport client.Since, the default transport in
Provider
isBoxTransport
, there exists friction when working with types that wrap a Provider. It becomes necessary to add theT: Transport
generic to `Foo<P: Provider, T: Transport + Clone>>.The following (cleaner) way isn't possible:
Solution
Box the transport after instantiating
RpcClient
using.boxed
PR Checklist