feat: port reth pooled tx type #1767
Merged
+566
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
reviewed
Dec 7, 2024
There was a problem hiding this comment.
yep, decode impls would just need to be same as TxEnvelope
wondering if it would also make sense to just make TxEnvelope generic over Eip4844 variant? then we can just do type PooledTransaction = TxEnvelope<TxEIp4844WithSidecar> and won't need to duplicate any code
|
hmm, good question. The imo this extra type isn't too bad, and I'd rather have it separate |
mattsse
force-pushed
the
matt/port-reth-pooled-tx
branch
from
a2322a2 to
d1ac383
Compare
Co-authored-by: Arsenii Kulikov <klkvrr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
migrates the reth
PooledTransactionElementtype and renames it to justPooledTransaction.@klkvr I assume we can simplify the decode/encode impls now