feat: reth's block body fns #1775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just brought these fns at the moment since the rest explicitly use |
mattsse
requested changes
Dec 10, 2024
Comment on lines
184
to
194
| /// Returns true if the transaction is an EIP-4844 transaction. | ||
| #[inline] | ||
| fn is_eip4844(&self) -> bool { | ||
| self.ty() == EIP4844_TX_TYPE_ID | ||
| } | ||
|
|
||
| /// Returns true if the transaction is an EIP-7702 transaction. | ||
| #[inline] | ||
| fn is_eip7702(&self) -> bool { | ||
| self.ty() == EIP7702_TX_TYPE_ID | ||
| } |
There was a problem hiding this comment.
these are no longer necessary with #1773
stevencartavia
requested review from
DaniPopes,
gakonst and
onbjerg
as code owners
mattsse
requested changes
Dec 11, 2024
crates/consensus/src/block/mod.rs
Outdated
Comment on lines
96
to
100
| /// Helper for blob_transactions_iter function | ||
| #[inline] | ||
| fn is_eip4844(tx: &T) -> bool { | ||
| tx.is_eip4844() | ||
| } |
There was a problem hiding this comment.
this function is not needed and can be removed
crates/consensus/src/block/mod.rs
Outdated
Comment on lines
108
to
112
| /// Returns only the blob transactions, if any, from the block body. | ||
| #[inline] | ||
| pub fn blob_transactions(&self) -> Vec<&T> { | ||
| self.blob_transactions_iter().collect() | ||
| } |
There was a problem hiding this comment.
this should be an impl Iterator instead because this is mostly useful when iterating over blob txs
mattsse
approved these changes
Dec 11, 2024
mattsse
force-pushed
the
reth-BlockBody-fns
branch
from
41d400e to
9147cbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
paradigmxyz/reth#12519
Solution
Brought BlockBody fns from reth to replace reth's BlockBody type with alloy's
PR Checklist