Add edge case tests for extract_value
and fix the newly discovered bug
#1808
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add two edge case tests for
extract_value
in https://github.com/alloy-rs/alloy/blob/main/crates/node-bindings/src/utils.rs#L26, which extract values given keys from the line of text.When there is no comma (like extract
value
from string"key: value"
), the function will fail the test.Also add doc to better explain this function.
Solution
The code uses different patterns for finding values for keys ending with '=' and ': ', as shown below. By changing them into the same pattern, the issue is fixed. 10 tests in
utils.rs
are all passed.PR Checklist