Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add readmes #3

Merged
merged 5 commits into from
Aug 28, 2023
Merged

docs: add readmes #3

merged 5 commits into from
Aug 28, 2023

Conversation

prestwich
Copy link
Member

No description provided.

@prestwich prestwich added the documentation Improvements or additions to documentation label Aug 28, 2023
@prestwich prestwich requested review from gakonst and DaniPopes August 28, 2023 19:42
@prestwich prestwich self-assigned this Aug 28, 2023
README.md Outdated
feature is enabled, compilation for the `getrandom` crate will fail. This is
expected: see [their documentation][getrandom] for more details.

To fix this, either disable the `"getrandom"` feature on `alloy-core` or add
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

outdated, probably just remove this paragraph

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah can you also remove from core?

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
crates/providers/README.md Outdated Show resolved Hide resolved
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can resolve CI in a follow up

@prestwich prestwich merged commit 2fdc053 into main Aug 28, 2023
@prestwich prestwich deleted the prestwich/readme-and-cleanup branch October 28, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants