Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: std feature flag for alloy-consensus #461

Merged
merged 4 commits into from
Apr 5, 2024

Conversation

clabby
Copy link
Contributor

@clabby clabby commented Apr 4, 2024

Overview

Ports alloy-consensus to be a no_std compatible crate.

@clabby clabby force-pushed the cl/alloy-consensus-no-std branch 2 times, most recently from cb5ba59 to d296ccf Compare April 4, 2024 17:30
@clabby clabby marked this pull request as ready for review April 4, 2024 17:30
@clabby clabby changed the title feat: Port alloy-consensus to no_std feat: std feature flag for alloy-consensus Apr 4, 2024
@clabby clabby force-pushed the cl/alloy-consensus-no-std branch from d296ccf to 09e7d29 Compare April 4, 2024 17:34
@clabby clabby marked this pull request as draft April 4, 2024 17:35
Copy link
Member

@prestwich prestwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meeds update to the no_std list in the readme

@DaniPopes
Copy link
Member

There's also scripts/check_no_std.sh

@clabby clabby marked this pull request as ready for review April 4, 2024 22:26
@clabby clabby force-pushed the cl/alloy-consensus-no-std branch from d54cf29 to 349762a Compare April 4, 2024 22:28
@clabby clabby requested a review from prestwich April 4, 2024 22:35
@clabby clabby force-pushed the cl/alloy-consensus-no-std branch from 349762a to 416c41d Compare April 5, 2024 01:03
@prestwich prestwich force-pushed the cl/alloy-consensus-no-std branch from 416c41d to 1755db8 Compare April 5, 2024 03:39
@prestwich
Copy link
Member

rebased onto main after #454 to re-run CI with new changes. shouldn't be any conflicts, but 454 was big. will merge after CI passes

@prestwich prestwich merged commit 796308f into alloy-rs:main Apr 5, 2024
18 checks passed
ben186 pushed a commit to ben186/alloy that referenced this pull request Jul 27, 2024
* feat: Port `alloy-consensus` to `no_std`

enable `std` feature everywhere

* fmt

* review

* fix wasm build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants