-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: std
feature flag for alloy-consensus
#461
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clabby
force-pushed
the
cl/alloy-consensus-no-std
branch
2 times, most recently
from
April 4, 2024 17:30
cb5ba59
to
d296ccf
Compare
clabby
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
Evalir
as code owners
April 4, 2024 17:30
clabby
changed the title
feat: Port
feat: Apr 4, 2024
alloy-consensus
to no_std
std
feature flag for alloy-consensus
clabby
force-pushed
the
cl/alloy-consensus-no-std
branch
from
April 4, 2024 17:34
d296ccf
to
09e7d29
Compare
prestwich
reviewed
Apr 4, 2024
prestwich
requested changes
Apr 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meeds update to the no_std list in the readme
There's also |
clabby
force-pushed
the
cl/alloy-consensus-no-std
branch
from
April 4, 2024 22:28
d54cf29
to
349762a
Compare
prestwich
reviewed
Apr 5, 2024
clabby
force-pushed
the
cl/alloy-consensus-no-std
branch
from
April 5, 2024 01:03
349762a
to
416c41d
Compare
prestwich
approved these changes
Apr 5, 2024
enable `std` feature everywhere
prestwich
force-pushed
the
cl/alloy-consensus-no-std
branch
from
April 5, 2024 03:39
416c41d
to
1755db8
Compare
rebased onto main after #454 to re-run CI with new changes. shouldn't be any conflicts, but 454 was big. will merge after CI passes |
3 tasks
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
* feat: Port `alloy-consensus` to `no_std` enable `std` feature everywhere * fmt * review * fix wasm build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Ports
alloy-consensus
to be ano_std
compatible crate.