feat(provider): support ethCall optional blockId serialization #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerosnacks
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
Evalir
as code owners
mattsse
requested changes
Jun 14, 2024
crates/provider/src/provider/call.rs
Outdated
Comment on lines
28
to
30
| if let Some(block) = self.block { | ||
| seq.serialize_element(&block)?; | ||
| } |
There was a problem hiding this comment.
here we need to always serialize if overrides are set because overrides must be third argument
DaniPopes
reviewed
Jun 17, 2024
mattsse
requested changes
Jun 17, 2024
mattsse
approved these changes
Jun 17, 2024
mattsse
deleted the
zerosnacks/support-optional-blockid-serialization-ethcall
branch
onbjerg
added a commit
that referenced
this pull request
Jun 18, 2024
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
…-rs#900) * make block optional, update len * add test cases, accomplishing expected if I understood the requirements correctly * preserve_order not required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #896
Solution
lenPR Checklist