Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update builders to vector of strings in privacy struct #983

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Update builders to vector of strings in privacy struct #983

merged 1 commit into from
Jun 28, 2024

Conversation

igorline
Copy link
Contributor

Motivation

According to mev-share specification builders are specified by their names which you can find on this page

https://github.com/flashbots/dowg/blob/main/builder-registrations.json

Solution

Updated datatype to accept strings

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@igorline igorline mentioned this pull request Jun 27, 2024
Closed
@leruaa
Copy link
Contributor

leruaa commented Jun 27, 2024

@igorline The Privacy struct is used for eth_sendBundle also, see:

alloy/crates/rpc-types-mev/src/eth_calls.rs

Line 180 in 097e21a

pub privacy: Option<Privacy>,

So I think you should add a generics Privacy<T> setting it to Address for eth_ and String for mev_.

@igorline
Copy link
Contributor Author

igorline commented Jun 27, 2024 via email

@igorline
Copy link
Contributor Author

@leruaa eth_sendBundle according to specification does not have privacy field https://github.com/flashbots/mev-share/blob/09d9ea87d4f907aa69ffd914802209ae8ea680a4/specs/bundles/refund-recipient.md#eth_sendbundle

but eth_sendPrivateTransaction does have this field, though again builders are specified using their names according to this https://docs.flashbots.net/flashbots-auction/advanced/rpc-endpoint#eth_sendprivatetransaction

Am I missing something?

@leruaa
Copy link
Contributor

leruaa commented Jun 28, 2024

@igorline No you are right, I read too fast, sorry!

mattsse
mattsse approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this correct @leruaa ?

crates/rpc-types-mev/src/common.rs Outdated Show resolved Hide resolved
@igorline
fix(mev): builders as vector of strings in privacy struct
a3a2c3c 
according to mev-share specification builders are specified by their
names which you can find on this page

https://github.com/flashbots/dowg/blob/main/builder-registrations.json
@mattsse mattsse merged commit a2182f4 into alloy-rs:main Jun 28, 2024
22 checks passed
@igorline igorline deleted the builders-strings branch June 28, 2024 15:09
ben186 pushed a commit to ben186/alloy that referenced this pull request Jul 27, 2024
@igorline
Update builders to vector of strings in privacy struct (alloy-rs#983)
6f462b0 
fix(mev): builders as vector of strings in privacy struct

according to mev-share specification builders are specified by their
names which you can find on this page

https://github.com/flashbots/dowg/blob/main/builder-registrations.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@prestwich prestwich Awaiting requested review from prestwich

@Evalir Evalir Awaiting requested review from Evalir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igorline @leruaa @mattsse