Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Full function signature parsing #389

Closed
Evalir opened this issue Oct 27, 2023 · 2 comments · Fixed by #682
Closed

[Feature] Full function signature parsing #389

Evalir opened this issue Oct 27, 2023 · 2 comments · Fixed by #682

Comments

@Evalir
Copy link
Contributor

Evalir commented Oct 27, 2023

It would be nice for Function to be able to parse a full function signature e.g function foo(uint256 a, uint256 b) external returns (uint256)—this functionality is required in foundry and human-readable ABI strings fall short for view modifiers.
@Evalir Evalir mentioned this issue Oct 27, 2023
Merged
@gakonst
Copy link
Member

gakonst commented Nov 17, 2023

Can this be closed?

@DaniPopes DaniPopes mentioned this issue Nov 18, 2023
Merged
3 tasks
@DaniPopes
Copy link
Member

This is only missing parsing modifiers like external

@DaniPopes DaniPopes mentioned this issue Jun 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add support for parsing visibility and state mutability alloy-rs/core
3 participants
@gakonst @Evalir @DaniPopes