Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(json-abi): permit keyword prefixes in HR parser #420

Merged
merged 2 commits into from
Nov 18, 2023
Merged

feat(json-abi): permit keyword prefixes in HR parser #420

merged 2 commits into from
Nov 18, 2023

Conversation

DaniPopes
Copy link
Member

Motivation

Ref #389

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@DaniPopes DaniPopes changed the title feat(json-abi): permit keywords in HR parser feat(json-abi): permit keyword prefixes in HR parser Nov 18, 2023
mattsse
mattsse approved these changes Nov 18, 2023
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

crates/json-abi/src/utils.rs Outdated Show resolved Hide resolved
@DaniPopes DaniPopes merged commit 2468d4f into main Nov 18, 2023
20 checks passed
@DaniPopes DaniPopes deleted the dani/relax-hr-parser branch November 18, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@prestwich prestwich Awaiting requested review from prestwich prestwich is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaniPopes @mattsse