Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Define Signature trait #766

Open
emhane opened this issue Oct 8, 2024 · 2 comments · May be fixed by #782
Open

[Feature] Define Signature trait #766

emhane opened this issue Oct 8, 2024 · 2 comments · May be fixed by #782
Assignees
@grandima
Labels
debt Refactor of code section that is hard to understand or maintain good first issue Good for newcomers

Comments

@emhane
Copy link
Contributor

emhane commented Oct 8, 2024

Component

primitives

Describe the feature you would like

Add methods in Signature impl into new trait, and impl new trait for Signature. Add as super traits any From<T> etc impls for Signature.

Additional context

No response
@emhane emhane added good first issue Good for newcomers debt Refactor of code section that is hard to understand or maintain labels Oct 8, 2024
@grandima
Copy link

Hi @emhane
I see this issue marked as "good first issue". I'd like to get to know with the the project and implement it. Can you assign this to me?

@grandima grandima linked a pull request Oct 23, 2024 that will close this issue
Open
3 tasks
@emhane
Copy link
Contributor Author

emhane commented Oct 27, 2024

we probably also want something like

#[cfg(not(feature = "rlp"))]
trait SignatureSuperTrait {}

#[cfg(feature = "rlp")]
trait SignatureSuperTrait: alloy_rlp::Encodable + alloy_rlp::Decodable {}

pub trait Signature: .. + SignatureSuperTrait {
    ...
}

but can do this as separate issue too

@emhane emhane mentioned this issue Oct 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grandima grandima

Labels
debt Refactor of code section that is hard to understand or maintain good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add Signature trait grandima/core
3 participants
@grandima @emhane and others