feat: transaction trait

[edisontim]

Transaction trait has been partially implemented but it's missing a few trait bounds as well as the behavior of reth_primitives::Transaction
Closes #11533

[edisontim]

Hey @emhane ! Could you have a look at this one please?

[emhane]

good job so far

[mattsse]

with these things I recommend starting smol, we can always add more functionality later

[emhane]

revert this, we don't want to require Compact be a super trait for Transaction

[emhane]

almost there

[emhane]

another idea for arbitrary feature, is to do smthg like this in order to use it as super trait independently of FullTransaction, as you initially thought, but without requiring impl of another trait TransactionInner on transaction types alloy-rs/core#766 (comment)
so for this case it would be

#[cfg(not(feature = "arbitrary"))]
trait MaybeArbitrary {}

#[cfg(feature = "arbitrary")]
trait MaybeArbitrary: for<'a> arbitrary::Arbitrary<'a> {}

pub trait Transaction: .. + MaybeArbitrary {
    ..
}

but we can merge this pr as is and make that change in a follow up pr

[edisontim]

another idea for arbitrary feature, is to do smthg like this in order to use it as super trait independently of FullTransaction, as you initially thought, but without requiring impl of another trait TransactionInner on transaction types alloy-rs/core#766 (comment) so for this case it would be

#[cfg(not(feature = "arbitrary"))]
trait MaybeArbitrary {}

#[cfg(feature = "arbitrary")]
trait MaybeArbitrary: for<'a> arbitrary::Arbitrary<'a> {}

pub trait Transaction: .. + MaybeArbitrary {
    ..
}

but we can merge this pr as is and make that change in a follow up pr

That makes sense!

[mattsse]

lgtm, pending @emhane suggestions

[emhane]

Suggested change

#[cfg(feature = "arbitrary")]