Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sol-macro): correctly print Custom types in parameters #425

Merged
merged 2 commits into from
Nov 21, 2023
Merged

fix(sol-macro): correctly print Custom types in parameters #425

merged 2 commits into from
Nov 21, 2023

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Nov 21, 2023 •
edited
Loading

Motivation

Follow-up fix to #422

Previously custom type in parameters would get formatted as "tuple" even when not tuples, like enums.

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

mattsse
mattsse approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DaniPopes DaniPopes merged commit 2809e8b into main Nov 21, 2023
20 checks passed
@DaniPopes DaniPopes deleted the dani/sol-abi-param branch November 21, 2023 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@prestwich prestwich Awaiting requested review from prestwich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaniPopes @mattsse