Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add gcp-signer #165

Merged
merged 6 commits into from
Dec 9, 2024
Merged

feat: add gcp-signer #165

merged 6 commits into from
Dec 9, 2024

Conversation

codeWhizperer
Copy link
Contributor

@codeWhizperer codeWhizperer commented Dec 9, 2024 •
edited by zerosnacks
Loading

Closes: #14

PR Checklist

  • Added Documentation
  • Breaking changes

@codeWhizperer
Copy link
Contributor Author

@zerosnacks I have made the changes

@zerosnacks zerosnacks self-requested a review December 9, 2024 17:18
zerosnacks
zerosnacks approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@zerosnacks zerosnacks left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I don't have a good means of testing this but this is in accordance with the test case and example given in the Alloy repo

@zerosnacks zerosnacks merged commit 77848d0 into alloy-rs:main Dec 9, 2024
4 checks passed
@zerosnacks zerosnacks mentioned this pull request Dec 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zerosnacks zerosnacks zerosnacks approved these changes

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add GCP signer example
2 participants
@codeWhizperer @zerosnacks