This repository has been archived by the owner on Jan 12, 2024. It is now read-only.
add assumed and ignored tests #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
densvr
reviewed
Oct 24, 2019
| @@ -179,4 +182,28 @@ open class AllureRunListener(private val lifecycle: AllureLifecycle = AllureComm | |||
| return container | |||
| } | |||
|
|
|||
| private fun getIgnoredMessage(description: Description): StatusDetails { | |||
| val ignore = description.getAnnotation(Ignore::class.java) | |||
| val message = if ((ignore != null) && ignore.value.isNotEmpty()) | |||
There was a problem hiding this comment.
if (ignore?.value?.isNotEmpty() == true)
densvr
reviewed
Oct 24, 2019
| return StatusDetails(message = message) | ||
| } | ||
|
|
||
| private fun createTestResult(description: Description): TestResult { |
There was a problem hiding this comment.
Можно createTestResult(description: Description): TestResult = TestResult(
)
densvr
reviewed
Oct 24, 2019
| Label("testClass", description.className), | ||
| Label("testMethod", description.methodName), | ||
| Label("suite", getClassDisplayName(description))) | ||
| + getLabels(description) |
There was a problem hiding this comment.
Почему бы эти лейблы тоже не генерить в getLabels()?
There was a problem hiding this comment.
Так было изначально, я пока думаю не трогать
densvr
reviewed
Oct 24, 2019
| @@ -2,6 +2,7 @@ apply plugin: 'kotlin' | |||
|
|
|||
| dependencies { | |||
| implementation "org.jetbrains.kotlin:kotlin-stdlib:${kotlinVersion}" | |||
| implementation "junit:junit:${jUnitVersion}" | |||
There was a problem hiding this comment.
будет рефакторинг - думаю снесу здесь и везде
densvr
approved these changes
Oct 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.