This repository has been archived by the owner on Jan 12, 2024. It is now read-only.
Add current AllureAndroidListener to other listeners in bundle #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Badya
suggested changes
Feb 28, 2018
| @@ -12,7 +13,14 @@ import android.support.test.runner.AndroidJUnitRunner | |||
| @Keep | |||
| open class AllureAndroidRunner : AndroidJUnitRunner() { | |||
| override fun onCreate(arguments: Bundle) { | |||
| arguments.putCharSequence("listener", AllureAndroidListener::class.java.name) | |||
| val oldListeners: String? = arguments.getString("listener") | |||
There was a problem hiding this comment.
usage of getString is not so universal as getCharSequence
There was a problem hiding this comment.
if you look at source code in AOSP, they used bundle.getString(ARGUMENT_LISTENER) in listeners parsing
| listenersStringBuilder.append(",") | ||
| } | ||
| listenersStringBuilder.append(AllureAndroidListener::class.java.name) | ||
| arguments.putCharSequence("listener", listenersStringBuilder.toString()) |
There was a problem hiding this comment.
it can be written more kotlin-way, e. g:
arguments.putCharSequence("listener", arguments.getCharSequence("listener")
?.let {
"$it,${AllureAndroidListener::class.java.name}"
}
?: AllureAndroidListener::class.java.name)
Grigory-Rylov
force-pushed
the
dont_clear_old_run_listeners
branch
from
70857b3 to
2b5ec67
Compare
Badya
approved these changes
Mar 1, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't clear other listeners in bundle.