-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reqnroll adapter #463
Merged
Merged
Reqnroll adapter #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delatrie
force-pushed
the
commons-fixes-2403
branch
from
March 28, 2024 10:50
efc568a
to
61705d9
Compare
delatrie
force-pushed
the
reqnroll-adapter
branch
from
March 28, 2024 10:56
e611755
to
37e8c37
Compare
delatrie
force-pushed
the
commons-fixes-2403
branch
from
March 28, 2024 13:20
61705d9
to
0a561ad
Compare
delatrie
force-pushed
the
reqnroll-adapter
branch
from
March 28, 2024 13:30
37e8c37
to
5019dcc
Compare
epszaw
approved these changes
Mar 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like the reporter organization! Good job there! 👍
delatrie
force-pushed
the
reqnroll-adapter
branch
from
March 28, 2024 21:49
5019dcc
to
9c01478
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
A new adapter for Reqnroll. It was implemented from scratch with just some parts taken from Allure.SpecFlow.
The following issues were fixed compared to Allure.SpecFlow:
reqnroll.json
.allureConfig.json
can be omitted entirely (see Default format for gherkin tags #439).nameColumn
orvalueColumn
while havingallure.gherkinPatterns.stepArguments.createFromDataTables
set to true doesn't lead to ArgumentNullException (see Omitting paramNameRegex and paramValueRegex results in error #440).Closes #453