Update Kotlin and Kotlin Serialization libraries #37
Conversation
|
|
|
it will be nice to merge fast 👍 |
| android.enableJetifier=true |
There was a problem hiding this comment.
why it still use android.enableJetifier=true ? as I saw in allure-kotlin-android you don't use any old support libraries
There was a problem hiding this comment.
Yup, seems redundant ATM. When this code was being written some libraries were still not ported to androidx.
|
I have the similar problem, waiting for merge <3 |
| import java.io.File | ||
| import java.io.IOException | ||
| import java.io.InputStream | ||
| import java.util.UUID | ||
|
|
||
| class FileSystemResultsWriter(private val outputDirectory: File) : AllureResultsWriter { | ||
| private val mapper: Json = Json(JsonConfiguration(prettyPrint = true, useArrayPolymorphism = true)) | ||
| private val mapper: Json = Json { prettyPrint = true; useArrayPolymorphism = true } |
There was a problem hiding this comment.
minor: please break a line to avoid using semicolon
Json {
prettyPrint = true
useArrayPolymorphism = true
}
| android.enableJetifier=true | ||
|
|
||
| org.gradle.caching=true |
There was a problem hiding this comment.
Thanks for the improvements : ] Those properties should speed up the builds a little bit
|
I was about to push the code formatting and the Jetifier changes now but I guess it can be done later. |
Updated
Fixes #38