Added 5 minute interval align for time select buttons #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, I agree with this behavior. CI fails on formatting. You can run |
|
@almarklein - should be fixed now. I thought I fixed all formatting issues but somehow missed one. |
almarklein
approved these changes
Oct 26, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @almarklein,
I stumbled across #216 which is a behavior I could make use of as well.
This PR adds support for interval alignment during time select using the +/- buttons.
In this version fractions of the interval/step size (e.g. 42) will be align during the first button press to the respective step size (e.g. 45). Afterwards each step will align with the step size.
Let me know what you think about this change.