Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes iOS zoom issue #456

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Fixes iOS zoom issue #456

merged 2 commits into from
Mar 14, 2024

Conversation

axelknock
Copy link
Contributor

@axelknock axelknock commented Mar 10, 2024

On iOS there is a common feature on all browsers where inputs with text under a certain size cause the view to zoom in to compensate. On a Progressive Web App this zoom cannot be reverted, requiring the app to be re-opened.
This pull request simply sets the inputs I found to have relative sizes to fixed 16px size to prevent the issue from happening.

Demonstration of the issue:
https://github.com/almarklein/timetagger/assets/72520178/48c91ccb-d626-4b03-9f1a-8494e470de5c

@almarklein
Copy link
Owner

There's another one a few lines down (for duration). I think these are all of 'm.

@axelknock
Copy link
Contributor Author

I changed the further dialog. I also confirmed that there were no other cases of percentage sizing of text inputs:

Exported grep results:

timetagger/common/cred.html:98:            <input id='input_u' type='text' placeholder='username' /><br />
timetagger/pages/login.md:69:<input id='input_u' type='text' placeholder='username' style='margin:4px;'/><br />
timetagger/app/dialogs.py:676:                <input type='text' style='flex:1; min-width: 50px; font-size: 16px;' />
timetagger/app/dialogs.py:684:                <input type='text' style='flex:1; min-width: 50px; font-size: 16px;' />
timetagger/app/dialogs.py:691:            <input type='text' style='flex: 1; min-width: 50px; font-size: 16px' />
timetagger/app/dialogs.py:1524:                <input type='text' style='width:100%;' spellcheck='true' />
timetagger/app/dialogs.py:2005:            <input type='text' style='width: 100px; border: 5px solid #eee' spellcheck='false' />
timetagger/app/dialogs.py:2276:                <input type='text' spellcheck='false' />
timetagger/app/dialogs.py:2421:                <input type='text' style='width:100%;' spellcheck='false' />

I also went through the interface on mobile looking for input fields that caused the zoom issue and could find none. I also found that loading a browser through the PWA (by selecting the guide for example) caused the display to refresh, so that can work as an alternative to restarting.

@almarklein almarklein merged commit 52d8a3a into almarklein:main Mar 14, 2024
9 checks passed
@almarklein
Copy link
Owner

Thanks for this contribution, and for taking the time to search for more cases!

@axelknock axelknock deleted the ios-zoom-fix branch March 14, 2024 12:49
stavros-k referenced this pull request in truecharts/public May 1, 2024
…v24.4.1@5f4c178 by renovate (#21018)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[ghcr.io/almarklein/timetagger](https://togithub.com/almarklein/timetagger)
| major | `v23.11.4-nonroot` -> `v24.4.1-nonroot` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>almarklein/timetagger (ghcr.io/almarklein/timetagger)</summary>

###
[`v24.4.1`](https://togithub.com/almarklein/timetagger/releases/tag/v24.4.1)

[Compare
Source](https://togithub.com/almarklein/timetagger/compare/v23.11.4...v24.4.1)

##### App

- Fixes iOS zoom issue by
[@&#8203;axelknock](https://togithub.com/axelknock) in
[https://github.com/almarklein/timetagger/pull/456](https://togithub.com/almarklein/timetagger/pull/456)
- Add option for Monday-Friday week by
[@&#8203;staddi99](https://togithub.com/staddi99) in
[https://github.com/almarklein/timetagger/pull/458](https://togithub.com/almarklein/timetagger/pull/458)
- More shortcuts by [@&#8203;Tagirijus](https://togithub.com/Tagirijus)
in
[https://github.com/almarklein/timetagger/pull/467](https://togithub.com/almarklein/timetagger/pull/467)
- Enable notifications by
[@&#8203;almarklein](https://togithub.com/almarklein) in
[https://github.com/almarklein/timetagger/pull/470](https://togithub.com/almarklein/timetagger/pull/470)

##### For self-hosters

- Pass an import string rather than a function reference to enable
multi-worker and reload support. by
[@&#8203;michaellenaghan](https://togithub.com/michaellenaghan) in
[https://github.com/almarklein/timetagger/pull/457](https://togithub.com/almarklein/timetagger/pull/457)
- add a script to merge records of multiple databases by
[@&#8203;joergsteffens](https://togithub.com/joergsteffens) in
[https://github.com/almarklein/timetagger/pull/455](https://togithub.com/almarklein/timetagger/pull/455)

##### New Contributors

- [@&#8203;michaellenaghan](https://togithub.com/michaellenaghan) made
their first contribution in
[https://github.com/almarklein/timetagger/pull/457](https://togithub.com/almarklein/timetagger/pull/457)
- [@&#8203;axelknock](https://togithub.com/axelknock) made their first
contribution in
[https://github.com/almarklein/timetagger/pull/456](https://togithub.com/almarklein/timetagger/pull/456)
- [@&#8203;staddi99](https://togithub.com/staddi99) made their first
contribution in
[https://github.com/almarklein/timetagger/pull/458](https://togithub.com/almarklein/timetagger/pull/458)
- [@&#8203;joergsteffens](https://togithub.com/joergsteffens) made their
first contribution in
[https://github.com/almarklein/timetagger/pull/455](https://togithub.com/almarklein/timetagger/pull/455)
- [@&#8203;Tagirijus](https://togithub.com/Tagirijus) made their first
contribution in
[https://github.com/almarklein/timetagger/pull/467](https://togithub.com/almarklein/timetagger/pull/467)

##### Personal note

I'm rather occupied with other projects, so I find that I don't have as
much time to work on TimeTagger as I want to. In the last days I did
some work on timetagger.app to refactor things into more components with
specific tasks, which will make room for future improvements such as
teams ...

**Full Changelog**:
almarklein/timetagger@v23.11.4...v24.4.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMDkuMCIsInVwZGF0ZWRJblZlciI6IjM3LjMwOS4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbInVwZGF0ZS9kb2NrZXIvZ2VuZXJhbC9tYWpvciJdfQ==-->

Signed-off-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com>
Co-authored-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants