Backspace can unselect all tags now #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok now only one test failed, the linting one. Did I do something wrong with the code formatting or so? |
almarklein
reviewed
Jul 18, 2024
|
Thanks! I forgot about this PR. I fixed the formatting and merged. In the future, you can run |
|
Cool thanks for the info and thanks for merging. I recently found a bug, though. When pressing |
|
I cannot reproduce the bug, and also don't see how that could be happening. For good measure I did #497 so |
truecharts-admin
referenced
this pull request
in truecharts/public
Jul 24, 2024
…v24.07.1@bfbc2d9 by renovate (#24202) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/almarklein/timetagger](https://togithub.com/almarklein/timetagger) | minor | `v24.4.1-nonroot` -> `v24.07.1-nonroot` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>almarklein/timetagger (ghcr.io/almarklein/timetagger)</summary> ### [`v24.07.1`](https://togithub.com/almarklein/timetagger/releases/tag/v24.07.1) [Compare Source](https://togithub.com/almarklein/timetagger/compare/v24.4.1...v24.07.1) ##### App - Changed that the "now"-line was barely visible in darkmode by [@​Tagirijus](https://togithub.com/Tagirijus) in [https://github.com/almarklein/timetagger/pull/476](https://togithub.com/almarklein/timetagger/pull/476) - Use standalone display for better user experience on Android. by [@​vchigrin](https://togithub.com/vchigrin) in [https://github.com/almarklein/timetagger/pull/491](https://togithub.com/almarklein/timetagger/pull/491) - Fix recursion error due to early dates by [@​almarklein](https://togithub.com/almarklein) in [https://github.com/almarklein/timetagger/pull/494](https://togithub.com/almarklein/timetagger/pull/494) - Prevent negative timestamps, warn users when dates look odd by [@​almarklein](https://togithub.com/almarklein) in [https://github.com/almarklein/timetagger/pull/495](https://togithub.com/almarklein/timetagger/pull/495) - Make date visible on FireFix by [@​almarklein](https://togithub.com/almarklein) in [https://github.com/almarklein/timetagger/pull/496](https://togithub.com/almarklein/timetagger/pull/496) - Set stop button color based on running tag. by [@​vchigrin](https://togithub.com/vchigrin) in [https://github.com/almarklein/timetagger/pull/492](https://togithub.com/almarklein/timetagger/pull/492) - Backspace can unselect all tags now by [@​Tagirijus](https://togithub.com/Tagirijus) in [https://github.com/almarklein/timetagger/pull/484](https://togithub.com/almarklein/timetagger/pull/484) - Tweak unselecting with backspace by [@​almarklein](https://togithub.com/almarklein) in [https://github.com/almarklein/timetagger/pull/497](https://togithub.com/almarklein/timetagger/pull/497) - Support for multiple date formats by [@​almarklein](https://togithub.com/almarklein) in [https://github.com/almarklein/timetagger/pull/498](https://togithub.com/almarklein/timetagger/pull/498) ##### Other - Update test for new asgineer by [@​almarklein](https://togithub.com/almarklein) in [https://github.com/almarklein/timetagger/pull/483](https://togithub.com/almarklein/timetagger/pull/483) ##### New Contributors - [@​vchigrin](https://togithub.com/vchigrin) made their first contribution in [https://github.com/almarklein/timetagger/pull/491](https://togithub.com/almarklein/timetagger/pull/491) **Full Changelog**: almarklein/timetagger@v24.4.1...v24.07.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNiIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC42IiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbImF1dG9tZXJnZSIsInVwZGF0ZS9kb2NrZXIvZ2VuZXJhbC9ub24tbWFqb3IiXX0=-->
|
I finally found some time testing + updating. For now I also cannot reproduce it. Maybe it was some hiccup or so. Thanks again for merging! (= |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I reset my branch, since with my recent PR #480 I accidentally had all my recent changes combined in one PR, which was not my intention. Also I now added things to the GUI to properly reflect the new feature.