Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide scaladoc in inspections #1110

Merged
merged 4 commits into from
May 5, 2023

Conversation

alexarchambault
Copy link
Member

No description provided.

alexarchambault and others added 2 commits May 5, 2023 16:46
Co-authored-by: Alex Archambault <alexandre.archambault@gmail.com>
@kiendang
Copy link
Collaborator

kiendang commented May 5, 2023

Thanks for cleaning this up. Feels so good to have this finally merged. I read through the code and it's exactly how I wanted it to be.

@alexarchambault
Copy link
Member Author

@kiendang Thanks to you for having brought the idea and worked on it in a first time! I’m really glad I’ve finally been able to have time to push it over the finish line

@alexarchambault alexarchambault changed the title Inspect Provide scaladoc in inspections May 15, 2023
@kiendang
Copy link
Collaborator

May I know how to try this out?

I tried a launcher both from source

./mill launcher

and release

coursier bootstrap --standalone almond:0.13.4 --scala 2.13 --default=true --sources -o almond213 -f

(without metabrowse)

but scaladoc didn't show. With the release launcher the kernel also crashed when I tried shift-tabbing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants