Add Support for Post-interrupt Hooks #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
piiteraq
commented
Jul 5, 2023
piiteraq
commented
- Added support for post-interrupts hooks to e.g. allow remote jobs kicked off from a Jupyter notebook cell to be interrupted when the cell itself is interrupted
- An example was added to 'api-jupyter.md' to demonstrate how to add a post-interrupt hook in PREDEFS code of an Almond based kernel for stopping Spark jobs
piiteraq
pushed a commit
to piiteraq/almond
that referenced
this pull request
Jul 26, 2023
- This is a rework of almond-sh#1186 to make the post-interrupt hook feature work as intended
piiteraq
pushed a commit
to piiteraq/almond
that referenced
this pull request
Jul 26, 2023
- This is a rework of almond-sh#1186 to make the post-interrupt hook feature work as intended
piiteraq
pushed a commit
to piiteraq/almond
that referenced
this pull request
Jul 26, 2023
- This is a rework of almond-sh#1186 to make the post-interrupt hook feature work as intended
piiteraq
pushed a commit
to piiteraq/almond
that referenced
this pull request
Jul 26, 2023
- This is a rework of almond-sh#1186 to make the post-interrupt hook feature work as intended
piiteraq
pushed a commit
to piiteraq/almond
that referenced
this pull request
Jul 26, 2023
- This is a rework of almond-sh#1186 to make the post-interrupt hook feature work as intended
piiteraq
pushed a commit
to piiteraq/almond
that referenced
this pull request
Aug 13, 2023
- This is a rework of almond-sh#1186 to make the post-interrupt hook feature work as intended
alexarchambault
added a commit
that referenced
this pull request
Aug 21, 2023
* Add Fixes for Post-Interrupt Hook Feature - This is a rework of #1186 to make the post-interrupt hook feature work as intended * Renaming afterInterruptHook -> postInterruptHook * Remove setInstance / getInstanceOpt stuff By passing the JupyterApi to Execute methods when needed * Log from JupyterApiImpl * Clean-up log messages * NIT Format * fixup --------- Co-authored-by: Peter Christensen <pchristensen2@apple.com> Co-authored-by: Alexandre Archambault <alexandre.archambault@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.