Update ammonite to Scala 3 toolchain #1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexarchambault
force-pushed
the
update-ammonite
branch
from
46b7860 to
98ad471
Compare
alexarchambault
force-pushed
the
update-ammonite
branch
from
98ad471 to
ad13a02
Compare
Seems some of its classes are a problem for the next commit's changes, giving errors like: ``` Error: error while loading SocketType, Error: class file org/zeromq/SocketType.class is broken, reading aborted with class java.lang.RuntimeException Error: bad constant pool index: 0 at pos: 1840 Error: -- [E006] Not Found Error: /home/runner/work/almond/almond/modules/shared/channels/src/main/scala/almond/channels/zeromq/ZeromqSocketImpl.scala:20:14 Error: 20 | socketType: SocketType, Error: | ^^^^^^^^^^ Error: | Not found: type SocketType Error: | Error: | longer explanation available when compiling with `-explain` ``` This reverts commit e6dc050.
alexarchambault
force-pushed
the
update-ammonite
branch
4 times, most recently
from
a7b6264 to
2013165
Compare
Co-Authored-By: Alexandre Archambault <alexandre.archambault@gmail.com>
alexarchambault
force-pushed
the
update-ammonite
branch
from
2013165 to
7fa2e52
Compare
alexarchambault
changed the title
|
Merged, thanks @lolgab! (for this PR, and the corresponding work in Ammonite too) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies