Remove 'scrub access limited' SQL #3254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original intention was to keep this as the main copy of the SQL sanitisation script (the script that is applied to data when it is copied from Production to Integration in the nightly env sync). A code comment deleted here refers to https://github.com/alphagov/env-sync-and-backup/blob/master/sanitising-sql/sanitise_content_publisher_production.sql, which is the 'copy' of this main copy, and should be kept in sync. The env sync process has since moved from env-sync-and-backup to govuk-helm-charts. The SQL script is referred to here: https://github.com/alphagov/govuk-helm-charts/blob/61d36eeb6339c13600f1c5cecc725a71ff593053/charts/db-backup/values.yaml#L329 ...and the SQL script it is referring to lives here: https://github.com/alphagov/govuk-helm-charts/blob/main/charts/db-backup/scripts/content-publisher.sql There is currently a TODO comment in that repo: ``` -- TODO: Fix the CI in alphagov/content-publisher to pull in this script -- (perhaps via git submodule) instead of running tests against its own copy. ``` So let's do that. This commit removes our local copy of the SQL sanitisation, and pulls in the remote copy instead (the version that is actually used in the env sync job, which is far more useful).
ChrisBAshton
added a commit
to alphagov/govuk-helm-charts
that referenced
this pull request
Sep 16, 2024
This is done as of alphagov/content-publisher#3254
lauraghiorghisor-tw
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original intention was to keep this as the main copy of the SQL sanitisation script (the script that is applied to data when it is copied from Production to Integration in the nightly env sync). A code comment deleted here refers to https://github.com/alphagov/env-sync-and-backup/blob/master/sanitising-sql/sanitise_content_publisher_production.sql, which is the 'copy' of this main copy, and should be kept in sync.
The env sync process has since moved from env-sync-and-backup to govuk-helm-charts. The SQL script is referred to here: https://github.com/alphagov/govuk-helm-charts/blob/61d36eeb6339c13600f1c5cecc725a71ff593053/charts/db-backup/values.yaml#L329
...and the SQL script it is referring to lives here: https://github.com/alphagov/govuk-helm-charts/blob/main/charts/db-backup/scripts/content-publisher.sql
There is currently a TODO comment in that repo:
So let's do that.
This commit removes our local copy of the SQL sanitisation, and pulls in the remote copy instead (the version that is actually used in the env sync job, which is far more useful).
Follow these steps if you are doing a Rails upgrade.