Get tests to run locally #3260
Merged
Get tests to run locally #3260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minhngocd
force-pushed
the
local-test-fix
branch
from
19c361d
to
b8ab145
Compare
|
I wonder if it would be good to note down in the documentation somewhere, that you'd need to check out the helm charts. |
ChrisBAshton
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
LGTM 👍 agree with Laura we could add a quick note about the requirement, in https://github.com/alphagov/content-publisher?tab=readme-ov-file#running-the-test-suite
The Github pipelines are checking out helm charts, whereas it is not doing so locally. Changing the test to look at a local version of helm-charts. Unfortunately this means that we are tied to having the helm charts repo checked out to get it passing locally.
minhngocd
force-pushed
the
local-test-fix
branch
from
b8ab145
to
a5b15f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Github pipelines are checking out helm charts, whereas it is not doing so locally, so tests are failing locally.
Changing the test to look at a relative path version of helm-charts so it passes both locally and in CI. Unfortunately this means that we are tied to having the helm charts repo checked out to get it passing locally.
Follow these steps if you are doing a Rails upgrade.