Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure hosts for application #3277

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Configure hosts for application #3277

merged 1 commit into from
Oct 10, 2024

Conversation

brucebolt
Copy link
Member

Note: the healthcheck endpoints are requested by IP, not domain, so we need to specifically exclude them from the protection.

Trello card

@brucebolt
Configure hosts for application
03c58fd 
Note: the healthcheck endpoints are requested by IP, not domain, so we
need to specifically exclude them from the protection.
@ChrisBAshton ChrisBAshton merged commit c67319e into main Oct 10, 2024
12 checks passed
@ChrisBAshton ChrisBAshton deleted the add-hosts branch October 10, 2024 13:51
@brucebolt
Copy link
Member Author

I've realised this allows domains like app-name.dodgygov.uk. The regex will need to be updated to app-name\..*\.gov.uk$.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisBAshton ChrisBAshton ChrisBAshton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brucebolt @ChrisBAshton