-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to ruby 2.7.1 #1395
Upgrade to ruby 2.7.1 #1395
Conversation
7a0e239
to
8c94819
Compare
I think it'd be beneficial to include the .ruby-version change as part of this for a few reasons: allows using syntax for 2.7, makes it easier to double check in review the quantity of warnings we'll have to deal with, and one less thing to review/deploy when ready. For the places where we're doing argument forwarding it'd be good if we could use the email-alert-api/app/services/application_service.rb Lines 2 to 4 in 8c94819
to
which would mean we could avoid adding the double splats in: app/services/immediate_email_generation_service.rb, app/services/matched_content_change_generation_service.rb and a few more. I notice we still get about 5 warnings still about kwargs in 2.7, is that something we're experiencing in most repos? I see CSV and RSpec are the culprits here, do we know if they have upgrade plans? |
Operator forwarding was only added in Ruby 2.7 so we'd need to deploy either both the Ruby upgrade and the app at the same time or deploy the Ruby upgrade first and then the app upgrade to fix it with Ruby 2.7. I'd be nervous about using a version specific feature during the deployment process and maybe that's something that should be addressed via a Rubocop rule in a later deploy?
Looks like the CSV error is because the app is using the |
Very sorry for the long delay, I started writing a reply but must have never finished. I just suggested using CSV directly for consistency with our existing approach - I don't know enough about the choice to have a preference, though |
640ee69
to
cfca91a
Compare
cfca91a
to
56217e1
Compare
Warning: Passing the keyword argument as the last hash parameter is deprecated See https://blog.bigbinary.com/2020/04/14/ruby-2-7-deprecates-conversion-of-keyword-arguments.html There are some warnings that come from gems outside hte project, e.g. rspec-mocks
56217e1
to
298f429
Compare
5b6d18c
to
298f429
Compare
These are the changes necessary for the app to run on Ruby 2.7.1.
I have left the version of Ruby the same, since there is a script that can be run after all the apps have been updated to update the version all at once.
Still some warnings coming from Rspec-mocks, the fix has not been merged yet