Run search term standardise function on GA4 search event #3229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshGDS
added
the
do-not-merge
AshGDS
force-pushed
the
ga4-standardise-search-term
branch
from
a680c1b to
c58fe8a
Compare
AshGDS
force-pushed
the
ga4-standardise-search-term
branch
from
c58fe8a to
102e5ff
Compare
AshGDS
changed the title
AshGDS
removed
the
do-not-merge
AshGDS
force-pushed
the
ga4-standardise-search-term
branch
from
102e5ff to
47084e6
Compare
andysellick
approved these changes
Dec 8, 2023
|
Thanks @andysellick - I have added a couple commits to this branch as I realised I can add another test, as well as updating the documentation. I have created a PR for Would you be able to review the extra commits I've added? Thanks 👍 |
andysellick
approved these changes
Dec 8, 2023
AshGDS
force-pushed
the
ga4-standardise-search-term
branch
from
d5984e0 to
0107e65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow these steps if you are doing a Rails upgrade.
What
Run
standardiseSearchTermon the GA4 search event, so that it looks the same as all the other search terms that come through e.g. in the ecommerce and pageview events.Why
https://trello.com/c/J5XcLlvh/743-collect-undefined-instead-of-when-removing-search-terms-on-finders