All content finder autocomplete: Finish AB test #3583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the AB test for autocomplete on the all content finder and makes it permanent.
csutter
added
the
do-not-merge
|
|
leenagupte
approved these changes
Nov 29, 2024
leenagupte
changed the title
leenagupte
force-pushed
the
remove-autocomplete-ab
branch
from
cc2ef1a to
afb7239
Compare
Autocomplete uses a denylist to stop certain terms from serving suggestions. The process to update the denylist is very manual and developer heavy. It might be difficult to update the denylist over the holiday period. In that situation the decision might be taken to temporarily turn off autocomplete entirely. An environment variable is used to determine whether or not to render search with autocomplete. The value of this variable will be applied globally across all applications that use site search. This environment variable will either exist, or not. The value of it doesn't really matter. If it exists, then search with autocomplete should be disabled. A value of "1" is used in the tests, as that is the default value being set in the helm charts. See alphagov/govuk-helm-charts#2832
leenagupte
force-pushed
the
remove-autocomplete-ab
branch
from
afb7239 to
5c5cb5b
Compare
kevindew
approved these changes
Dec 10, 2024
kevindew
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the AB test for autocomplete on the all content finder and makes it permanent.