Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded banner code #3601

Merged
merged 1 commit into from
Dec 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions app/models/content_item.rb
Original file line number Diff line number Diff line change
Expand Up @@ -164,10 +164,6 @@ def is_licence_transaction?
base_path == "/find-licences"
end

def has_user_research_banner?
base_path == "/business-finance-support"
end

private

attr_reader :content_item_hash
Expand Down
10 changes: 0 additions & 10 deletions app/views/finders/_show_header.html.erb
Original file line number Diff line number Diff line change
@@ -1,14 +1,4 @@
<div class="govuk-width-container">
<% if content_item.has_user_research_banner? %>
<div class="<% if !inverse %> govuk-!-margin-top-4 <% end %>">
<%= render "govuk_publishing_components/components/intervention", {
suggestion_text: "Help improve GOV.UK",
suggestion_link_text: "Sign up to take part in user research (opens in a new tab)",
suggestion_link_url: "https://survey.take-part-in-research.service.gov.uk/jfe/form/SV_2bggmg6xlelrO0S",
new_tab: true,
} %>
</div>
<% end %>
<div class="govuk-grid-row">
<div class="govuk-grid-column-two-thirds">
<% if content_item.all_content_finder? %>
Expand Down
2 changes: 1 addition & 1 deletion app/views/layouts/finder_layout.html.erb
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<% content_for :body do %>

<%= yield :before_content %>

<%= render "govuk_web_banners/recruitment_banner" %>
<main id="content" class="finder-frontend-content">
<div class="finder-frontend">
<%= yield %>
Expand Down
Loading