Clean up after long lists #1631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidBiddle
force-pushed
the
clean-up-after-long-lists
branch
2 times, most recently
from
4c77762 to
2fdd7f8
Compare
DavidBiddle
changed the title
DavidBiddle
force-pushed
the
clean-up-after-long-lists
branch
from
2fdd7f8 to
ea86376
Compare
alice-carr
previously approved these changes
Dec 2, 2024
DavidBiddle
changed the title
DavidBiddle
force-pushed
the
clean-up-after-long-lists
branch
from
ea86376 to
00c9b07
Compare
thomasiles
approved these changes
Dec 6, 2024
This flag is no longer used in the code, so we can remove it from the groups database. We can also remove the rake tasks that turn the flag on and off.
We've built new routes and controllers for configuring selection questions, so the old ones are no longer used. This commit removes them.
Removes the selections_settings view, which is no longer used. This also makes the 'selections_settings' translation block redundant, so this commit also: - removes most of the translations in this block altogether - moves the translations which are still used elsewhere into more appropriate blocks
We've removed the controller and the view for the old 'selections settings' controller, so we can now safely get rid of the input object.
We put the new selection files in 'long_lists_selection' folders, to distinguish them from the old selection logic. Since the old selection files have been removed, we no longer need this distinction, so we can rename the `long_lists_selection` to just `selection`. This commit does the rename for the selection/type input object.
We put the new selection files in 'long_lists_selection' folders, to distinguish them from the old selection logic. Since the old selection files have been removed, we no longer need this distinction, so we can rename the `long_lists_selection` to just `selection`. This commit does the rename for the selection/options input object.
We put the new selection files in 'long_lists_selection' folders, to distinguish them from the old selection logic. Since the old selection files have been removed, we no longer need this distinction, so we can rename the `long_lists_selection` to just `selection`. This commit does the rename for the selection/bulk_options input object.
We put the new selection files in 'long_lists_selection' folders, to distinguish them from the old selection logic. Since the old selection files have been removed, we no longer need this distinction, so we can rename the `long_lists_selection` to just `selection`. This commit does the rename for the selection/type view.
We put the new selection files in 'long_lists_selection' folders, to distinguish them from the old selection logic. Since the old selection files have been removed, we no longer need this distinction, so we can rename the `long_lists_selection` to just `selection`. This commit does the rename for the selection/options view.
We put the new selection files in 'long_lists_selection' folders, to distinguish them from the old selection logic. Since the old selection files have been removed, we no longer need this distinction, so we can rename the `long_lists_selection` to just `selection`. This commit does the rename for the selection/bulk_options view.
We put the new selection files in 'long_lists_selection' folders, to distinguish them from the old selection logic. Since the old selection files have been removed, we no longer need this distinction, so we can rename the `long_lists_selection` to just `selection`. This commit does the rename for all three selection controllers.
We used name scheme 'long_lists_selection_#{controller}_#{action}_path'
for the new selection routes, to distinguish them from the old selection
routes.
Since the old selection routes have been removed, we no longer need this
distinction, so we can use 'selection_#{controller}_#{action}_path' as
our name scheme instead.
This commit does the rename for the selection/type controller.
We used name scheme 'long_lists_selection_#{controller}_#{action}_path'
for the new selection routes, to distinguish them from the old selection
routes.
Since the old selection routes have been removed, we no longer need this
distinction, so we can use 'selection_#{controller}_#{action}_path' as
our name scheme instead.
This commit does the rename for the selection/options controller.
We used name scheme 'long_lists_selection_#{controller}_#{action}_path'
for the new selection routes, to distinguish them from the old selection
routes.
Since the old selection routes have been removed, we no longer need this
distinction, so we can use 'selection_#{controller}_#{action}_path' as
our name scheme instead.
This commit does the rename for the selection/bulk_options controller.
This test file uses variables to store the paths it's looking for. We originally named these with `long_lists` to avoid a name collision with the old selection routes. Those old routes no longer exist, so we can rename the variables to make them simpler and more consistent with the route names.
The old selection logic used the phrase 'selections settings' and variations on that. That logic no longer exists, but the wording still existed in the names of some tests (likely because they were copied or adapted from old tests). This commit changes this to 'selection options' which is the language the newer logic uses.
The `with_selections_settings` trait was using the plural `selections`. This was consistent with the old selection logic, but inconsistent with both the other settings traits (e.g. `with_date_settings`) and the new selection logic (which uses the singular `selection`). This commit renames all instances of `with_selections_settings` to the singular `with_selection_settings`.
DavidBiddle
force-pushed
the
clean-up-after-long-lists
branch
from
00c9b07 to
4d347e1
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: https://trello.com/c/BFWKD1ZG/2541-clean-up-after-long-lists-work
Includes:
long_lists_enableddatabase column and the task for setting it.long list selection(since the distinction doesn't make sense now that the old selection files have been removed). We can just sayselectioninsteadlong_list_selectionwith_selections_settingstrait to the singularwith_selection_settingsfor consistencyNeeds doing elsewhere:
Don't merge this until:
Note on how big this PR is
This PR is big in terms of the number of files touched and the number of commits. The changes themselves are fairly straightforward (largely deletions and renames), but there are a lot of them.
It would be easiest to go through it commit-by-commit.
If you reckon it's too unwieldy, let me know and I'll try to break it into a few PRs.
Things to consider when reviewing