Update organisation fetcher with dry run version #1650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamJamCul
force-pushed
the
add-dry-run-org-fetch-task
branch
from
b18302f to
b706d52
Compare
lfdebrux
previously approved these changes
Dec 4, 2024
SamJamCul
force-pushed
the
add-dry-run-org-fetch-task
branch
from
b706d52 to
3d83f2f
Compare
lfdebrux
approved these changes
Dec 5, 2024
The OrganisationFetcher now takes a `dry_run` argument, which will toggle between the dry run and actual fetch process. The dry run will not make any changes to the database, and instead will list out all the proposed changes. When iterating over the organisations from the API, any new additions will be presented, and any changes to existing orgs will have their changes presented. The rake task that makes use of this has also been updated to incorporate this
SamJamCul
force-pushed
the
add-dry-run-org-fetch-task
branch
from
3d83f2f to
3c086a2
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OrganisationFetcher now takes a
dry_runargument, which will toggle between the dry run and actual fetch process. The dry run will not make any changes to the database, and instead will list out all the proposed changes.When iterating over the organisations from the API, any new additions will be presented, and any changes to existing orgs will have their changes presented.
The rake task that makes use of this has also been updated to incorporate this
What problem does this pull request solve?
Trello card: https://trello.com/c/M81WBlnp/2021-update-organisations-table-in-forms-admin-database
Modifying the
OrganisationFetcherso that it has a dry run variation. This doesn't result in any changes, but simply lists out any changes that would happen if it weren't a dry run.Things to consider when reviewing