Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update content on question type usage reports #1655

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

chao-xian
Copy link
Contributor

These are changes from Content Designer.

What problem does this pull request solve?

Trello card: https://trello.com/c/UjsEZ7j0/2024-make-the-headings-and-links-on-the-lists-feature-report-clearer-and-accessible

See https://app.mural.co/t/gaap0347/m/gaap0347/1732873391465/c2022bda516a64db5ea1c2696dacdc100738284a

Screenshots of new changes

Screenshot 2024-12-05 at 5 18 47 PM

localhost_3000_reports_selection-questions-summary

Screenshot 2024-12-05 at 5 19 49 PM

Screenshot 2024-12-05 at 5 20 01 PM

Screenshot 2024-12-05 at 5 20 10 PM

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Has all relevant documentation been updated?

Copy link
Contributor

@alice-carr alice-carr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this all makes sense, and works locally for me 👍

These are changes from Content Designer.
@chao-xian chao-xian force-pushed the update-reports-content branch from d65197e to 27fa1b5 Compare December 9, 2024 15:16
@chao-xian chao-xian merged commit c4ad6dd into main Dec 9, 2024
4 checks passed
@chao-xian chao-xian deleted the update-reports-content branch December 9, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants