Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small tweaks to delete confirmation pages #1660

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Small tweaks to delete confirmation pages #1660

merged 2 commits into from
Dec 10, 2024

Conversation

lfdebrux
Copy link
Member

@lfdebrux lfdebrux commented Dec 10, 2024 •
edited
Loading

What problem does this pull request solve?

Trello card: https://trello.com/c/UThSZ8ga/2037-fix-behaviour-of-deleting-page-with-secondary-skip-route

Change the delete confirmations for deleting a question and deleting a form to be two-thirds width.

Also change the content when deleting a page to read "question" instead of "page" to be clearer.

Thanks @hannahkc and @christophercameron-ixd for spotting these changes were needed!

Screenshots

Confirmation page for deleting a form

Before
Screenshot of a Google Chrome browser window, showing localhost:3000/forms/19/delete. The page content reads Test deleting live form Are you sure you want to delete this draft? radio Yes radio No button Continue
After
Screenshot of a Google Chrome browser window, showing localhost:3000/forms/19/delete. The page content reads Test deleting live form Are you sure you want to delete this draft? radio Yes radio No button Continue

Confirmation page for deleting a question

Before
Screenshot of a Google Chrome browser window, showing localhost:3000/forms/19/pages/69/delete. The page content reads What’s your name? Are you sure you want to delete this page? radio Yes radio No button Continue
After
Screenshot of a Google Chrome browser window, showing localhost:3000/forms/19/pages/69/delete. The page content reads What’s your name? Are you sure you want to delete this question? radio Yes radio No button Continue

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Has all relevant documentation been updated?

lfdebrux and others added 2 commits December 10, 2024 09:18
@lfdebrux
Change delete confirmation to be two-thirds width
adc0d86 
By default all of our pages should be contained within two-thirds of the
viewport, using the GOV.UK Design System grid classes; this was missed
from the delete confirmation page for some reason. This commit fixes it.
@lfdebrux @hannahkc
Change title and heading for delete page confirmation
3c83c51 
This should read "Are you sure you want to delete this question?"

Co-authored-by: hannahkc <hannah.cooper@digital.cabinet-office.gov.uk>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
14.3% Duplication on New Code

See analysis details on SonarQube Cloud

@lfdebrux lfdebrux merged commit f217a74 into main Dec 10, 2024
8 checks passed
@lfdebrux lfdebrux deleted the ldeb-fix-delete-confirmation-templates branch December 10, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-carr alice-carr alice-carr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lfdebrux @alice-carr