Remove inspect config added in error #1673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Removes the `config.active_record.attributes_for_inspect` item set by the Rails app:update script - we use inspect in production for one of the organisation rake tasks, so this config change doesn't work for us. I added this in error when making the update to Rails 8.0.1 - it was a change from an earlier Rails update.
DavidBiddle
force-pushed
the
remove-id-inspect-config
branch
from
8d43fc1 to
a60fc3d
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card:
Removes the
config.active_record.attributes_for_inspectitem set by the Rails app:update script - we use inspect in production for one of the organisation rake tasks, so this config change doesn't work for us.I added this in error when making the update to Rails 8.0.1 - it was a change from an earlier Rails update.
Thanks @chao-xian for spotting this!
Things to consider when reviewing