Remove Alpine edge repositories from Dockerfile #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
lfdebrux
changed the title
jamie-o-wilkinson
approved these changes
Oct 13, 2023
😱 good spot! I'm relieved that wasn't there in the other PRs 😅 |
lfdebrux
changed the title
lfdebrux
force-pushed
the
ldeb-no-alpine-edge
branch
from
9bbf7e0 to
67f0d4c
Compare
In commit 6979388 we used both the stable and edge repos for Alpine because we wanted OpenSSL 3 in our app image. However, OpenSSL 3 is the default version of OpenSSL in Alpine 3.17.0 [[1]]. So we no longer have a need for edge. With Alpine 3.17 at the time of this commit fetching the edge repo index fails, so building this Dockerfile fails with the error: ``` Step 24/35 : RUN apk update ---> Running in 247913f7587d fetch https://dl-cdn.alpinelinux.org/alpine/v3.17/main/aarch64/APKINDEX.tar.gz fetch https://dl-cdn.alpinelinux.org/alpine/v3.17/community/aarch64/APKINDEX.tar.gz fetch http://dl-cdn.alpinelinux.org/alpine/edge/main/aarch64/APKINDEX.tar.gz ERROR: http://dl-cdn.alpinelinux.org/alpine/edge/main: BAD signature WARNING: Ignoring http://dl-cdn.alpinelinux.org/alpine/edge/main: No such file or directory v3.17.5-107-g07fd110f6bf [https://dl-cdn.alpinelinux.org/alpine/v3.17/main] v3.17.5-108-gfe9a155566d [https://dl-cdn.alpinelinux.org/alpine/v3.17/community] 1 errors; 17699 distinct packages available The command ‘/bin/sh -c apk update’ returned a non-zero code: 1 ``` The Alpine wiki says that > Warning: Do not enable stable and edge repos at the same time. This can break your system. Either use edge or stable. [[2]]. As we no longer need the edge repos, and it does not appear to work, this commit removes the use of edge from the Dockerfile. [1]: https://wiki.alpinelinux.org/wiki/Release_Notes_for_Alpine_3.17.0 [2]: https://wiki.alpinelinux.org/wiki/Repositories
lfdebrux
force-pushed
the
ldeb-no-alpine-edge
branch
from
67f0d4c to
035535e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
In commit 6979388 we used both the stable and edge repos for Alpine because we wanted OpenSSL 3 in our app image. However, OpenSSL 3 is the default version of OpenSSL in Alpine 3.17.0 [1]. So we no longer have a need for edge.
With Alpine 3.17 at the time of this commit fetching the edge repo index fails, so building this Dockerfile fails with the error:
The Alpine wiki says that
[2].
As we no longer need the edge repos, and it does not appear to work,
this commit removes the use of edge from the Dockerfile.
Things to consider when reviewing