Remove timestamp constraint #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliuk2012
reviewed
Nov 15, 2023
These were only made explicit to support a potential rollback to Grape as we migrated from there to Rails in the past. However this is now causing us issues as part of our Rails 7.1 upgrade [1] [1]: https://github.com/alphagov/forms-api/actions/runs/6876807358/job/18703161928?pr=369
chao-xian
force-pushed
the
remove-grape-timestamp-regression
branch
from
0e3299c to
28b81d3
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
aliuk2012
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were only made explicit to support a potential rollback to Grape as we migrated from there to Rails in the past. However this is now causing us issues as part of our Rails 7.1 upgrade 1
Things to consider when reviewing