-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add empty what happens next markdown field #371
Conversation
db/migrate/20231116142411_add_what_happens_next_markdown_to_forms.rb
Outdated
Show resolved
Hide resolved
bb55502
to
cd2ba71
Compare
cd2ba71
to
273bc81
Compare
db/migrate/20231116142411_add_what_happens_next_markdown_to_forms.rb
Outdated
Show resolved
Hide resolved
273bc81
to
c49d665
Compare
c49d665
to
cd93c71
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Does this have to change? https://github.com/alphagov/forms-api/blob/main/db/seeds.rb#L85 |
@aliuk2012 I don't think so at the moment - the seed still works and sets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested this locally and everything looks good. I tried using form-runner from main branch and also the feature branch and both cases worked perfectly.
What problem does this pull request solve?
Trello card: https://trello.com/c/AbPj2LRr/1191-allow-markdown-on-confirmation-page-what-happens-next-content
Adds a null
what_happens_next_markdown
field to the form. Also adds this null field to the most recentmade_live_form
.To do in other PRs:
Things to consider when reviewing