Delete the secondary skip for a branch route if the branching question is deleted #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't makes sense to have a secondary skip condition when the precondition skip route has been deleted, but that's currently what happens when you delete a page with a skip and secondary skip. Instead let's just delete all check conditions for a page when that page is deleted, same as we do for the routing conditions. This shouldn't have any other side effects, as the only case currently where a check condition isn't also a routing condition for a page is for a secondary skip.
|
thomasiles
approved these changes
Dec 6, 2024
lfdebrux
deleted the
ldeb-change-page-check-condition-to-dependent-delete
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: https://trello.com/c/UThSZ8ga/2037-fix-behaviour-of-deleting-page-with-secondary-skip-route
It doesn't makes sense to have a secondary skip condition when the precondition skip route has been deleted, but that's currently what happens when you delete a page with a skip and secondary skip.
Instead let's just delete all check conditions for a page when that page is deleted, same as we do for the routing conditions. This shouldn't have any other side effects, as the only case currently where a check condition isn't also a routing condition for a page is for a secondary skip.
Things to consider when reviewing