Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid deprecation warning in specs #287

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Avoid deprecation warning in specs #287

merged 1 commit into from
Oct 12, 2023

Conversation

chrisroos
Copy link
Contributor

DEPRECATION WARNING: Passing the class as positional argument is
deprecated and will be removed in Rails 7.2.

Please pass the class as a keyword argument:

serialize :permissions, type: Array

@chrisroos
Avoid deprecation warning in specs
89e5432 
> DEPRECATION WARNING: Passing the class as positional argument is
> deprecated and will be removed in Rails 7.2.
>
> Please pass the class as a keyword argument:
>
> serialize :permissions, type: Array
@chrisroos chrisroos marked this pull request as ready for review October 12, 2023 16:12
@floehopper floehopper self-assigned this Oct 12, 2023
floehopper
floehopper approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@floehopper floehopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chrisroos
Copy link
Contributor Author

Thanks, @floehopper 👍

@chrisroos chrisroos merged commit b82c152 into main Oct 12, 2023
16 checks passed
@chrisroos chrisroos deleted the avoid-deprecation-warning-in-specs branch October 12, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floehopper floehopper floehopper approved these changes

@chrislo chrislo Awaiting requested review from chrislo

Assignees

@floehopper floehopper

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisroos @floehopper