-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extra notes that detail how we use Dependabot #428
Conversation
Comment from @36degrees
My understanding is that this setting should be compatible with that way of working: Dependabot has write access to the repo, but not the required admin or maintainer that you've got protecting the master branch. Note: most of our repos don't have this protection. |
7222b3c
to
616f140
Compare
@heathd this PR makes a few tweaks to the notes to clarify the guidance we already have. The only actual change proposed is to enable: "Treat PR approval as a request to PR". Although we've checked "Allow auto-merging to be enabled on projects" for individual repos, this conflicts with the guidance about requiring at least one approving review. I've been unable to find any documentation about this feature, apart from informal discussion that it's equivalent to |
@@ -20,13 +20,18 @@ Update your dependencies frequently rather than in ‘big bang’ batches. This | |||
|
|||
There are tools which scan GitHub repositories and raise PRs when they find dependency updates. Teams at GDS are using: | |||
|
|||
* [Dependabot][] - used by GOV.UK, GOV.UK Pay and GovWifi. The GOV.UK team manual contains [guidance on using Dependabot][] and [how the PRs raised should be reviewed][] | |||
* [Dependabot][] - used by GOV.UK, GOV.UK Pay, GovWifi and Digital Marketplace. The GOV.UK docs contain [guidance on using Dependabot][] and [how the PRs raised should be reviewed][] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could add GOV.UK PaaS to this too - dependabot's used for the nodeJS frontend.
ah ok, so the "Allow auto-merging to be enabled on projects" is a different behaviour to the "Treat PR approval as a request to PR" function? If I understand correctly:
did I understand correctly? |
Previously we had regular discussion on GOV.UK about how we can make Dependabot less burdensome. This adds and consolidates the notes on Dependabot to record the outcome of those discussions, so we don't keep having them again, and again, and...
616f140
to
b10388e
Compare
Previously we had regular discussion on GOV.UK about how we can
make Dependabot less burdensome. This adds and consolidates the
notes on Dependabot to record the outcome of those discussions,
so we don't keep having them again, and again, and...
This PR was at one point a discussion area for a potential change for
an account setting. However, we decided to leave it as-is, and instead
add a note to explain why.