Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand languages #941

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Expand languages #941

merged 3 commits into from
Nov 5, 2024

Conversation

huwd
Copy link
Member

@huwd huwd commented Oct 7, 2024

One Login are using TypeScript / Node / JS a lot for backend so promoting it to a first class option.

We'll need to come back around for mobile languages - but will do that in a separate PR with an eye to style guides.

image

@huwd huwd force-pushed the expand-languages branch from f7e9929 to 62ad7d4 Compare October 7, 2024 17:48
@@ -59,18 +58,16 @@ Our core languages for backend development are:
- [Java](/manuals/programming-languages/java.html)
- [Python](/manuals/programming-languages/python/python.html)
- [Ruby](/manuals/programming-languages/ruby.html)
- [JavaScript / Node.js](/manuals/programming-languages/nodejs/index.html)
Copy link
Member Author

@huwd huwd Oct 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open for challenge on this... I never know what to call the thing. Do we refer to Language here -> JavaScript or Superset TypeScript or runtime Node.js

I use all three relatively interchangeably in speech, but should probably be more rigorous in docs... the slash feels like a cop-out.

Perhaps JavaScript is most right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is about languages rather than platforms, which it seems to be, then not Node. I think TypeScript is correct, because someone could definitely say TypeScript is not allowed if the GDS Way were to say JavaScript.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TypeScript / Node.js is better, particularly as a backend language. It's unlikely we'll want much regular JavaScript.

Copy link
Contributor

@galund galund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you asked a question that seemed to demand a pedantic answer, so sorry that's what you got!

Do you have a nice editor extension that's doing your curly quotes - I approve in principle if but we value consistency I wouldn't bother.

appropriate. For example, the GOV.UK PaaS team uses TypeScript
because they are used to working with a statically typed, compiled language,
and they think the compilation and static-analysis tooling is better for
their workflow. There's more information about TypeScript on the
their workflow. Ther’s more information about TypeScript on the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
their workflow. Ther’s more information about TypeScript on the
their workflow. There’s more information about TypeScript on the

@@ -59,18 +58,16 @@ Our core languages for backend development are:
- [Java](/manuals/programming-languages/java.html)
- [Python](/manuals/programming-languages/python/python.html)
- [Ruby](/manuals/programming-languages/ruby.html)
- [JavaScript / Node.js](/manuals/programming-languages/nodejs/index.html)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is about languages rather than platforms, which it seems to be, then not Node. I think TypeScript is correct, because someone could definitely say TypeScript is not allowed if the GDS Way were to say JavaScript.

Copy link

@DaveLee-GDS DaveLee-GDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It reads fine to me and is a worthy addition. It might be out of scope for this document, but is it worth stating something about recruitment possibly being easier by way of utilising a mainstream language that is more likely covered in the candidate pool?
Thats the only comment i could think to add.

@@ -59,18 +58,16 @@ Our core languages for backend development are:
- [Java](/manuals/programming-languages/java.html)
- [Python](/manuals/programming-languages/python/python.html)
- [Ruby](/manuals/programming-languages/ruby.html)
- [JavaScript / Node.js](/manuals/programming-languages/nodejs/index.html)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TypeScript / Node.js is better, particularly as a backend language. It's unlikely we'll want much regular JavaScript.

@huwd huwd merged commit c9ddd9a into main Nov 5, 2024
1 check passed
@huwd huwd deleted the expand-languages branch November 5, 2024 16:03
huwd added a commit that referenced this pull request Nov 5, 2024
I stupidly hit merge without noticing some old comments, I'm a fool.

This answers @galund's sensible point:
#941 (review)

> Do you have a nice editor extension that's doing your curly quotes - I
> approve in principle if but we value consistency I wouldn't bother.

At least I'll make this file consistent.

Also amends a silly typo i missed
@huwd
Copy link
Member Author

huwd commented Nov 5, 2024

I'm going to come back around on the TypeScript point, I think I agree but I'd rather get this up and tweak after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants