Merge pull request #287 from alphagov/acronym_error_fix

Prevent user error when incorrectly formatted footnotes are added to HTML attachments
alphagov · Aug 30, 2023 · 0798a1a · 0798a1a
2 parents ee3ffea + b9199e8
commit 0798a1a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+## Unreleased
+
+* Prevent user error when incorrectly formatted footnotes are added to HTML attachments ([#287](https://github.com/alphagov/govspeak/pull/287))
+
 ## 8.2.0
 
 * Reintroduce support for acronyms in Call To Action blocks and in Legislative Lists ([#285](https://github.com/alphagov/govspeak/pull/285))

diff --git a/lib/govspeak.rb b/lib/govspeak.rb
@@ -451,6 +451,8 @@ def encode(text)
     end
 
     def add_acronym_alt_text(html)
+      return unless html
+
       @acronyms.each do |acronym|
         html.gsub!(acronym[0], "<abbr title=\"#{acronym[1].strip}\">#{acronym[0]}</abbr>")
       end