Merge pull request #60 from alphagov/handle-no-rubygem

Catch exception when Rubygem does not exist

lib/change_set.rb

@@ -3,6 +3,9 @@ def internal?
     Net::HTTP.get(URI("https://rubygems.org/api/v1/gems/#{name}/owners.yaml"))
       .then { |response| YAML.safe_load response }
       .any? { |owner| owner["handle"] == "govuk" }
+  rescue NoMethodError
+    puts "This rubygem could not be found."
+    false
   end
 end
 

spec/lib/change_set_spec.rb

@@ -25,6 +25,15 @@
 
       expect(Dependency.new("foo").internal?).to eq(false)
     end
+
+    it "returns false if the dependency is not found in Rubygems" do
+      stub_request(:get, "https://rubygems.org/api/v1/gems/foo/owners.yaml")
+      .to_return(
+        body: "This rubygem could not be found.",
+      )
+
+      expect(Dependency.new("foo").internal?).to eq(false)
+    end
   end
 end