-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multiple commits edge case #61
Conversation
61a620b
to
4c12136
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you also need to make it verify that all commits are signed by Dependabot? (or do you already do that? apologies I've only v briefly skimmed the code here)
That happens here |
I don't think that does what you think it does 😅 |
Oh you mean verifying the GPG keys? |
d0bfc25
to
5d1c107
Compare
Yeah. I don't think it's currently even checking that Dependabot is the only committer. Pretty sure it's only checking that Dependabot raised the PR, which doesn't really tell us much. |
That's a good point, I'll raise a new PR to add that check! |
@sengi @ChrisBAshton I've raised #62 to address the commit signing issue. Both PRs are ready for review now. |
Swap conditionals around so we check a PR only has one commit first.
5d1c107
to
7853fef
Compare
Adding a commit to a Dependabot PR triggered an error where it expected a commit message in a Dependabot format. It should not proceed if there are multiple commits.
Trello